Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9627 )
Change subject: WIP: KUDU-2342. consensus: use tighter bound for non-voter promotion ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9627/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9627/1//COMMIT_MSG@20 PS1, Line 20: Note: While in consensus_queue.cc I also factored a couple of code > was it really necessary to combine the refactor and this bug fix/improvemen The new version is much easier to follow, I think, but you're right that they don't have to be the same patch. I think I can quickly split this into two patches: one with the refactor and one with the improvements. http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc@959 PS1, Line 959: if (queue_state_.mode == PeerMessageQueue::LEADER && : peer->last_exchange_status == PeerStatus::OK) { > agreed. That's correct, it's an improvement to the policy. And yes I can do that. -- To view, visit http://gerrit.cloudera.org:8080/9627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff517f01d6dc25eb15d01593dd57b7dc0dd25956 Gerrit-Change-Number: 9627 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 22:32:05 +0000 Gerrit-HasComments: Yes
