Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9627 )
Change subject: WIP: KUDU-2342. consensus: use tighter bound for non-voter promotion ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc@913 PS1, Line 913: TrackedPeer* peer, > It's a grey area based on my reading of the GSG. Since this is acting on a Fine, let it be as is. It's just a nit. http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc@976 PS1, Line 976: the current commit index, as measured > everywhere that I looked, last_received_current_leader() either gives Minim All right then. I just saw log messages where the committed configuration had OpId index == -1. http://gerrit.cloudera.org:8080/#/c/9627/1/src/kudu/consensus/consensus_queue.cc@977 PS1, Line 977: > if this is the first time we talked to this peer then prev_peer_state.last_ OK, thanks for the explanation and addressing that. -- To view, visit http://gerrit.cloudera.org:8080/9627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff517f01d6dc25eb15d01593dd57b7dc0dd25956 Gerrit-Change-Number: 9627 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:05:51 +0000 Gerrit-HasComments: Yes
