Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9374 )
Change subject: KUDU-2259: add real user to AuthenticationCredentialsPB ...................................................................... Patch Set 3: Code-Review+1 (2 comments) lgtm, just some whitespace nits to prevent future merge conflict pain http://gerrit.cloudera.org:8080/#/c/9374/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java: http://gerrit.cloudera.org:8080/#/c/9374/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java@155 PS3, Line 155: "Caller is responsible for refreshing credentials.", nit: goofy re-indentation here http://gerrit.cloudera.org:8080/#/c/9374/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java@204 PS3, Line 204: "before expiration."); same (and same a few places below) -- To view, visit http://gerrit.cloudera.org:8080/9374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d2d901d42501ecfc0f6372f68cf7335eb188b45 Gerrit-Change-Number: 9374 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 23:55:45 +0000 Gerrit-HasComments: Yes
