Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9642 )
Change subject: Factor out consensus queue methods ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/9642/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9642/1/src/kudu/consensus/consensus_queue.cc@932 PS1, Line 932: return; > I guess that is not intuitive. I don't think we can meaningfully set it in heh, I had the same confusion with this patch before I saw this comment thread. I think by renaming to something like 'bool* lmp_mismatch' as I suggested and then using the resulting out-var down below it might be fine to set to false in this case. -- To view, visit http://gerrit.cloudera.org:8080/9642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I278de150e3dc42181ccfbbd3a4c0e5cc4de90c1a Gerrit-Change-Number: 9642 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:15:58 +0000 Gerrit-HasComments: Yes
