Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9685 )
Change subject: [docs] Add remaining release notes for 1.7.0 ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@102 PS2, Line 102: target striping Nit: maybe just "will now stripe data" http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@103 PS2, Line 103: data directories instead of all data directories. This increases the likelihood Probably should add that in experiments we didn't see a measurable performance hit either. You can get the specifics from https://github.com/cloudera/kudu/commit/60276c54a221d554287c6645df7df542fe6d6443. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@120 PS2, Line 120: when exceptions are thrown, the stack trace indicates the correct location Nit: since "exceptions" are plural, should probably say "the stack traces indicate the correct locations where..." (i.e. convert everything to plural). Or convert "exceptions" to singular. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@125 PS2, Line 125: not include Nit: clearer as "exclude"? http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@180 PS2, Line 180: * Added name of the real user to AuthenticationCredentialsPB. This is used to : pass information on the user name when negotiating connections with SASL PLAIN : authentication. This part feels too detailed. Maybe get a more appropriate summary from Dan? http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@190 PS2, Line 190: * In scenarios where a tablet server were completely wiped and a new one were Nit: was (in the second 'were' too). http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@191 PS2, Line 191: tablet Nit: tablet server? http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@193 PS2, Line 193: but Nit: "and", I think (without the comma too). It's not clear that the default behavior would be to evict unless you're more familiar with the Raft protocol. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@197 PS2, Line 197: * The leader master now always sends a CA certificate and an authentication token Could you reword this to better explain the net effect on the user's experience? http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@210 PS2, Line 210: In order to avoid : recoverable failure in cases when masters are in the process of the very first : leader election after starting up. This reads like a sentence fragment. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@220 PS2, Line 220: JavaDoc Nit: $ git grep Javadoc | wc -l 16 $ git grep JavaDoc | wc -l 2 http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@243 PS2, Line 243: the current : hosts of tablet replicas Nit: "the hosts of the tablet's existing replicas", perhaps? -- To view, visit http://gerrit.cloudera.org:8080/9685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1718a2065663245a5bc438288013871566d6941b Gerrit-Change-Number: 9685 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 16:42:52 +0000 Gerrit-HasComments: Yes
