Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9685 )
Change subject: [docs] Add remaining release notes for 1.7.0 ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@102 PS2, Line 102: target striping s/target striping/stripe I think that would be more concise and clearer http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@109 PS2, Line 109: optional s/optional// optional is implied by 'offered' http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@148 PS2, Line 148: scanLocaliity s/scanLocaliity/scanLocality http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@150 PS2, Line 150: A new replica management scheme is implemented and enabled by default this doesn't do a good job of introducing what a 'replica management' scheme is, and the name is pretty jargony. How about something like this: The strategy Kudu uses for automatically healing tablets which have lost a replica due to server or disk failures has been improved. The new re-replication strategy, or replica management scheme, first adds ... http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@172 PS2, Line 172: improvement s/improvement/increase improvement was already used in the sentence. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@190 PS2, Line 190: were s/were/is (or maybe was?) here and at the end of the line http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@192 PS2, Line 192: would s/would/could http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@193 PS2, Line 193: will s/will// http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@192 PS2, Line 192: that previously hosted a replica at that location would be unable to contact : that replica, but not evict it 'unable to contact that replica, but not evict it' isn't clear. Typically you don't use two negatives conjoined with 'but'. Perhaps: ... in some cases, tablet replicas which were previously hosted on the tablet server are unable to be evicted from the Raft configuration. http://gerrit.cloudera.org:8080/#/c/9685/2/docs/release_notes.adoc@194 PS2, Line 194: the one s/the one// -- To view, visit http://gerrit.cloudera.org:8080/9685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1718a2065663245a5bc438288013871566d6941b Gerrit-Change-Number: 9685 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 16:56:11 +0000 Gerrit-HasComments: Yes
