Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9645 )
Change subject: KUDU-2303: Add KuduSchema::ToString implementation ...................................................................... Patch Set 6: (3 comments) Couple small things and then LGTM. http://gerrit.cloudera.org:8080/#/c/9645/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9645/6//COMMIT_MSG@8 PS6, Line 8: Now that you've also changed Schema::ToString(), can you mention in the commit message how you changed it and why? http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/client/schema.cc@741 PS6, Line 741: "" Can you make this return the same string as would be returned by an empty Schema, i.e. "Schema []", based on my other comment. http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/common/schema.cc@361 PS6, Line 361: \n\t\n I think "Schema []" is fine for the ToString() of a schema with no columns. -- To view, visit http://gerrit.cloudera.org:8080/9645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43958c3733bf273c810cc77068e8d69a3fb2f132 Gerrit-Change-Number: 9645 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 18:23:12 +0000 Gerrit-HasComments: Yes
