Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9645 )
Change subject: KUDU-2303: Add KuduSchema::ToString implementation ...................................................................... Patch Set 6: (1 comment) Just passing through with some feedback on the new test. http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/9645/6/src/kudu/client/client-test.cc@5537 PS6, Line 5537: TEST_F(ClientTest, TestKuduSchemaToString) { I think this new test would be more appropriate in client-unittest.cc, since it doesn't actually need a cluster (which client-test.cc provides). -- To view, visit http://gerrit.cloudera.org:8080/9645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43958c3733bf273c810cc77068e8d69a3fb2f132 Gerrit-Change-Number: 9645 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 16 Mar 2018 19:42:54 +0000 Gerrit-HasComments: Yes
