[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/9652 )
Change subject: KUDU-2346: Fix mac pkg-config/PKG_CONFIG_PATH issue. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9652/4/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/9652/4/thirdparty/build-thirdparty.sh@174 PS4, Line 174: if (( 1 -eq $(pkg-config --exists openssl) )); then > What if pkg-config returns anything else but 1 and 0 (e.g. no pkg-config ar That is a good question - pkg-config seems to be a requirement of the build process. $ grep -r pkg-config * | wc -l ... 541 Your suggestion is more concise and uses less variables though - I'm happy to use it. -- To view, visit http://gerrit.cloudera.org:8080/9652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1 Gerrit-Change-Number: 9652 Gerrit-PatchSet: 4 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Fri, 16 Mar 2018 23:12:26 +0000 Gerrit-HasComments: Yes
