Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9652 )
Change subject: KUDU-2346: Fix mac pkg-config/PKG_CONFIG_PATH issue. ...................................................................... Patch Set 6: (2 comments) Overall looks good, just a couple of nitpicks regarding the commit message. Thank you for the patch! http://gerrit.cloudera.org:8080/#/c/9652/6//COMMIT_MSG Commit Message: PS6: nit: I didn't notice that in the first review round, but this commit message contains lines of more than 72 characters long. Please update this commit message in accordance with the recommendations at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines You can find that link and more information at https://kudu.apache.org/docs/contributing.html http://gerrit.cloudera.org:8080/#/c/9652/6//COMMIT_MSG@10 PS6, Line 10: Macos nit: macOS -- To view, visit http://gerrit.cloudera.org:8080/9652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1 Gerrit-Change-Number: 9652 Gerrit-PatchSet: 6 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Sat, 17 Mar 2018 02:17:15 +0000 Gerrit-HasComments: Yes
