Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9737 )
Change subject: tools: return error when updating with no block manager instances ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9737/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/9737/1/src/kudu/fs/data_dirs.cc@a628 PS1, Line 628: > So where did we think we were enforcing this, and why is it no longer enfor I think the thought was that before, we could assume the metadata directory existed within the data dirs. Now that that's no longer true, we can't make that assumption. http://gerrit.cloudera.org:8080/#/c/9737/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/9737/1/src/kudu/tools/kudu-tool-test.cc@2198 PS1, Line 2198: no > not Done http://gerrit.cloudera.org:8080/#/c/9737/1/src/kudu/tools/kudu-tool-test.cc@2202 PS1, Line 2202: TEST_F(ToolTest, TestFsSwappingDirectoriesFailsGracefully) { > Could you also test this at the FsManager level, in fs_manager-test? Should Done -- To view, visit http://gerrit.cloudera.org:8080/9737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06d95f561301eebc21542e01782a8c219ca71c70 Gerrit-Change-Number: 9737 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 21 Mar 2018 19:57:38 +0000 Gerrit-HasComments: Yes
