Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9737
to look at the new patch set (#3).
Change subject: tools: return error when updating with no block manager
instances
......................................................................
tools: return error when updating with no block manager instances
Previously when running `kudu fs update_dirs` with a set of directories
that did not contain existing block manager instances, the tool would
fail a CHECK.
Prior to support for configurable metadata directories (6492633), the
CHECK was guaranteed, as at least the first data directory was
guaranteed to exist (or an error would be returned earlier on
otherwise). Now, rather than failing a CHECK, we should return an error.
If Kudu can't find any block manager instances, the following error is
returned instead:
Not found: cannot update data directories: could not open directory manager;
none of the provided data directories could be found.
Note that this only affects the `kudu fs update_dirs` tool; "normal"
opening of the FS layout would return errors if any block manager
instances are not found.
Change-Id: I06d95f561301eebc21542e01782a8c219ca71c70
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 66 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9737/3
--
To view, visit http://gerrit.cloudera.org:8080/9737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06d95f561301eebc21542e01782a8c219ca71c70
Gerrit-Change-Number: 9737
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
