Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9730 )
Change subject: [spark] improve log message to warn users to pass keytab/principal ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9730/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9730/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@376 PS1, Line 376: Log.warn(s"Please pass principal and keytab options for jobs running in cluster mode!") We should only be logging in the case that the Kudu cluster is secure. Unfortunately I don't think we can know that until we failed to connect. I think what we need to do for this is to make Kudu throw a more specific exception in the case that it can't connect due to lacking credentials, and then if we get that exception when we first connect to the cluster, we can issue the log? -- To view, visit http://gerrit.cloudera.org:8080/9730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I305494d6c10d73523fa65ef25faf90c5d86919c8 Gerrit-Change-Number: 9730 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 21 Mar 2018 22:53:10 +0000 Gerrit-HasComments: Yes
