Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9755 )
Change subject: [consensus] KUDU-2367 fix replica health report ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9755/2/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9755/2/src/kudu/consensus/consensus_queue.cc@567 PS2, Line 567: // Replicas which have been unreachable for too long are considered failed. Feels like we need some heuristic or logic for the ordering here, and to put that in a comment. I can't tell from just reading the code why this should be here instead of where it was before. -- To view, visit http://gerrit.cloudera.org:8080/9755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If77474adc8f618f2cda35f992190133138fdb511 Gerrit-Change-Number: 9755 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 22 Mar 2018 15:42:14 +0000 Gerrit-HasComments: Yes
