Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9755 )
Change subject: [consensus] KUDU-2367 fix replica health report ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1932 PS3, Line 1932: tablet-under-the-test nit: maybe clearer to say tablet being tested http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1933 PS3, Line 1933: falling fall http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1937 PS3, Line 1937: // failed replica: nit: failed replica is: http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1939 PS3, Line 1939: back nit: started back up http://gerrit.cloudera.org:8080/#/c/9755/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1994 PS3, Line 1994: delay = MonoDelta::FromSeconds(3 * kUnavaiableFailedSec); not quite sure i understand the purpose of this delay -- To view, visit http://gerrit.cloudera.org:8080/9755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If77474adc8f618f2cda35f992190133138fdb511 Gerrit-Change-Number: 9755 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 22 Mar 2018 21:54:53 +0000 Gerrit-HasComments: Yes
