Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9766 )
Change subject: consensus: Add consensus peers health reporting test ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc File src/kudu/integration-tests/consensus_peer_health_status-itest.cc: http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@60 PS3, Line 60: we cause a peer to go into : // a bad state, that nit: ... a replica goes into a bad state, its ... http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@97 PS3, Line 97: We'll TS typo or some words are dropped? http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@127 PS3, Line 127: const auto nit: it might be constexpr http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@136 PS3, Line 136: // Cycle this test twice. Why? Do you mind documenting the reasoning? http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@140 PS3, Line 140: Shutdown In addition to Shutdown(), would it make sense to call Pause() and verify that the status turns into UNKNOWN as well? http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@154 PS3, Line 154: follower_ts->uuid() nit: maybe, extract this into a local/scope variable and use it in this scope. http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/raft_consensus-itest-base.h File src/kudu/integration-tests/raft_consensus-itest-base.h: http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/raft_consensus-itest-base.h@50 PS3, Line 50: NO_SHUTDOWN nit: I think it might be something more generic meaning 'don not tamper with the tserver process', like DO_NOT_TAMPER, KEEP_RUNNING, DO_NOT_TOUCH etc. :) -- To view, visit http://gerrit.cloudera.org:8080/9766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65d787a3146749e36e33d78e253914a5ffe5762d Gerrit-Change-Number: 9766 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 23 Mar 2018 23:35:25 +0000 Gerrit-HasComments: Yes
