Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9766 )
Change subject: consensus: Add consensus peers health reporting test ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc File src/kudu/integration-tests/consensus_peer_health_status-itest.cc: http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@60 PS3, Line 60: a replica goes into a bad : // state, its health > It reads fine to me but I'll change it as suggested Thanks! http://gerrit.cloudera.org:8080/#/c/9766/3/src/kudu/integration-tests/consensus_peer_health_status-itest.cc@154 PS3, Line 154: > I've extracted a follower_uuid variable at the top of the test for readabil SGTM -- To view, visit http://gerrit.cloudera.org:8080/9766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65d787a3146749e36e33d78e253914a5ffe5762d Gerrit-Change-Number: 9766 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 24 Mar 2018 02:48:18 +0000 Gerrit-HasComments: Yes
