Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9781 )
Change subject: consensus: Expose health status in GetConsensusState() RPC ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9781/1/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: http://gerrit.cloudera.org:8080/#/c/9781/1/src/kudu/consensus/consensus.proto@479 PS1, Line 479: UNSPECIFIED_HEALTH_REPORT = 0; : EXCLUDE_HEALTH_REPORT = 1; : INCLUDE_HEALTH_REPORT = 2; > Did you see it's conflicted when you tried it? I'm not sure whether it would conflict with something that currently exists. I just don't see why we would want to name this such a general name (consensus::UNKNOWN) when it can be namespaced so we never have to worry about that potential issue. Also, for a request-parameter, UNSPECIFIED seems like a more accurate interpretation of the semantics than UNKNOWN, but if you think that's unclear then I'm happy to change it. http://gerrit.cloudera.org:8080/#/c/9781/1/src/kudu/consensus/consensus.proto@495 PS1, Line 495: . > That sounds reasonable as well, especially if you don't expect this to chan The health report might grow but I don't foresee us needing to control specific fields within the health report. If we do then we could add another value to the num like INCLUDE_BETTER_HEALTH_REPORT. If we're talking about something non-health-report related, I think we should just cross that bridge when we come to it. More likely than not, we'd just add another optional parameter to GetConsensusStateRequestPB for whatever that thing is, if we need it. -- To view, visit http://gerrit.cloudera.org:8080/9781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15b8931156183e1713b902d22abbc80ca393f6b9 Gerrit-Change-Number: 9781 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 23:49:37 +0000 Gerrit-HasComments: Yes
