Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9781 )
Change subject: consensus: Expose health status in GetConsensusState() RPC ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9781/1/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: http://gerrit.cloudera.org:8080/#/c/9781/1/src/kudu/consensus/consensus.proto@479 PS1, Line 479: UNSPECIFIED_HEALTH_REPORT = 0; : EXCLUDE_HEALTH_REPORT = 1; : INCLUDE_HEALTH_REPORT = 2; > no, this is a regular enum. it is not a class enum In C++11 you can have that syntax with regular enums as well. But it's just a nit, feel free to ignore. -- To view, visit http://gerrit.cloudera.org:8080/9781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15b8931156183e1713b902d22abbc80ca393f6b9 Gerrit-Change-Number: 9781 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Sat, 24 Mar 2018 01:31:17 +0000 Gerrit-HasComments: Yes
