Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 )
Change subject: KUDU-2364 Add extra check in ksck for tserver ID ...................................................................... Patch Set 2: > Patch Set 2: > > (1 comment) Actually I thought about removing the ping too as it's an unnecessary call, ListTablets will fail if the ping fails so there's no need to do a separate ping beforehand, but I decided it was out of scope for this change. Adding a GetStatus() would just add a second/third RPC call, so that's why I thought it would be better to "re-use" ListTablets(), plus it already had a method to compare UUIDs. -- To view, visit http://gerrit.cloudera.org:8080/9787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c18ba7af8eaa6f5e4d7842f18754d2c1e32526 Gerrit-Change-Number: 9787 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 24 Mar 2018 07:54:05 +0000 Gerrit-HasComments: No
