Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 )
Change subject: KUDU-2364 Add extra check in ksck for tserver ID ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9787/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9787/2//COMMIT_MSG@21 PS2, Line 21: 2ff411da5bbe177631ace5d > We'll need a more specific error message for the uuid mismatch case, and it I'm not sure how this should work. Currently ksck counts the number of !s.ok()-s and if it's larger than 0, it will print this message. Should I just count the number of RemoteErrors separately? Furthermore, how this method (Status Ksck::FetchInfoFromTabletServers()) returns a single Status, should I just change the message to something else than "Could not gather complete information from all tablet servers"? What if a TabletServer is not reachable and another is reachable but with a mismatched UUID? An old TabletServer is technically not reachable if this happens, there's just a new one on the same host:port. http://gerrit.cloudera.org:8080/#/c/9787/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/9787/2/src/kudu/tools/ksck_remote.cc@116 PS2, Line 116: tserver::ListTabletsRequestPB req; > I would argue for checking the UUID via GetStatus(). I think it makes sense ok, moved this check for client side. Should I leave the uuid check in the ListTablets then? http://gerrit.cloudera.org:8080/#/c/9787/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/9787/2/src/kudu/tserver/tablet_service.cc@1366 PS2, Line 1366: > Extra \? Done -- To view, visit http://gerrit.cloudera.org:8080/9787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c18ba7af8eaa6f5e4d7842f18754d2c1e32526 Gerrit-Change-Number: 9787 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 26 Mar 2018 16:31:26 +0000 Gerrit-HasComments: Yes
