Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9795 )
Change subject: [linked_list-test] fix flake with the 3-4-3 scheme ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc File src/kudu/integration-tests/linked_list-test.cc: http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@313 PS2, Line 313: WaitForReplicasReportedToMaster I don't see how NON_VOTER can be related to this because we only have 3 tablet servers and we create replicas on each one with a config of 3 voters on line 298 in BuildAndStart(). http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@314 PS2, Line 314: run_time kWaitTime? http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@316 PS2, Line 316: run_time I believe this should be kWaitTime, i.e. 30 seconds or so, and not related to the linked list test run time. -- To view, visit http://gerrit.cloudera.org:8080/9795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132206371e2935f1e0f39e9eacad866fde22c5b8 Gerrit-Change-Number: 9795 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 19:06:18 +0000 Gerrit-HasComments: Yes
