Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9795 )
Change subject: [linked_list-test] fix flake with the 3-4-3 scheme ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc File src/kudu/integration-tests/linked_list-test.cc: http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@313 PS2, Line 313: WaitForReplicasReportedToMaster > I don't see how NON_VOTER can be related to this because we only have 3 tab I added some comments and updated the commit messages. Hopefully, that helps to understand what that was a problem. http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@314 PS2, Line 314: run_time > kWaitTime? Per out discussion offline, I'm keeping it as run_time, but I just added a handy variable for better readability. http://gerrit.cloudera.org:8080/#/c/9795/2/src/kudu/integration-tests/linked_list-test.cc@316 PS2, Line 316: run_time > Oops, I missed where kWaitTime was defined. Since there was a comment for t I ran ~250 iterations of the test at ve0518.halxg.cloudera.com (TSAN build, both slow and fast variants) and didn't find any flakiness with current timeouts (was using --stress_cpu_threads=32). Also, run the test 1K times using dist_test, not a single failure. It seems somethings has changed and now we don't need that 5 seconds extra for TSAN builds. -- To view, visit http://gerrit.cloudera.org:8080/9795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132206371e2935f1e0f39e9eacad866fde22c5b8 Gerrit-Change-Number: 9795 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 22:34:55 +0000 Gerrit-HasComments: Yes
