Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 )
Change subject: Simplify OpId/Timestamp assignment and make it atomic ...................................................................... Patch Set 24: (5 comments) Just posting some nits on the commit message. I'll try to look at the after two weeks, if it's still around. http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@26 PS24, Line 26: also drop 'also'? http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@26 PS24, Line 26: it t ? http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@29 PS24, Line 29: non-atomically with separately from http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@35 PS24, Line 35: with it ? http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@39 PS24, Line 39: , replace with stop/dot ? -- To view, visit http://gerrit.cloudera.org:8080/7221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bedcc5c3708d06f48131f34ea14c835867b4800 Gerrit-Change-Number: 7221 Gerrit-PatchSet: 24 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 06:08:35 +0000 Gerrit-HasComments: Yes
