Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9806 )
Change subject: KUDU-2377: represent resource limits as uint64_t values ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9806/1/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/9806/1/src/kudu/util/threadpool.h@124 PS1, Line 124: ThreadPoolBuilder& set_min_threads(uint64_t min_threads); > per the style guide, I think these APIs should still take signed ints, othe Sure, but that means adjusting GetThreadPoolThreadLimit to establish kint64max as an upper bound, even if RLIMIT_NPROC is, say, kuint64max - 1. The approach I took here was to pass uint64_t all the way through to avoid such conversions, in part because we can then support not just absurdly large threadpools but EXTREMELY absurd threadpools, but more importantly because conversion code is more code. I take it from your suggestion that you'd prefer the cost of such conversion code over the loss of signed integers here? -- To view, visit http://gerrit.cloudera.org:8080/9806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9bb71af886f732f36a8c93876f47e7591aeadb Gerrit-Change-Number: 9806 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 27 Mar 2018 22:11:16 +0000 Gerrit-HasComments: Yes
