Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9806 )
Change subject: util: use uint64_t values for resource limits and adjust usages ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9806/2/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: http://gerrit.cloudera.org:8080/#/c/9806/2/src/kudu/fs/block_manager.cc@94 PS2, Line 94: if (ReadFileToString(env, "/proc/sys/fs/file-max", &buf).ok() && what do you think about incorporating this into Env::GetResourceLimit so it's not just a wrapper on getrlimit but also takes into account /proc? Logically it seems like it's part of the environment... but it's up to you if you disagree, I can also see the logic that Env should just wrap a system call. http://gerrit.cloudera.org:8080/#/c/9806/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/9806/2/src/kudu/util/env_posix.cc@1590 PS2, Line 1590: 2^63 2^64 right? -- To view, visit http://gerrit.cloudera.org:8080/9806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9bb71af886f732f36a8c93876f47e7591aeadb Gerrit-Change-Number: 9806 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 28 Mar 2018 21:40:33 +0000 Gerrit-HasComments: Yes
