Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9790 )
Change subject: KUDU-16 pt 2: add client-side limits on scanners ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9790/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/9790/4/src/kudu/client/client-test.cc@812 PS4, Line 812: TEST_F(ClientTest, TestRandomizedLimitScans) { If I'm reading client-test correctly, this only sets up a table with two tablets, and the first tablet only has 9 rows in it. Perhaps we should have some test which uses hash partitioning and ensures that each tablet has more than one batch worth of rows? http://gerrit.cloudera.org:8080/#/c/9790/4/src/kudu/client/scan_configuration.h File src/kudu/client/scan_configuration.h: http://gerrit.cloudera.org:8080/#/c/9790/4/src/kudu/client/scan_configuration.h@153 PS4, Line 153: return has_limit_; hm, why not use boost::optional here? -- To view, visit http://gerrit.cloudera.org:8080/9790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d40e3d14e36f3bf1d09a4bfdb3e17a745d244d Gerrit-Change-Number: 9790 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 02:07:26 +0000 Gerrit-HasComments: Yes
