Hello Will Berkeley,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9870

to review the following change.


Change subject: thirdparty: add patch to fix printing large span stats in /memz
......................................................................

thirdparty: add patch to fix printing large span stats in /memz

This fixes a bug that I introduced upstream in gperftools by
importing the upstream patch that fixed it. The issue was mismatched
arguments to printf() which resulted in incorrect printing of stats in
/memz.

Without this fix, memz always claimed to have 128 large spans:

>128   large *    128 spans ~    0.0 MiB;    2.7 MiB cum; unmapped: >0.0 MiB;   
> 0.0 MiB cum

With the fix it properly reports 0 spans on startup of an empty master:

>128   large *      0 spans ~    0.0 MiB;    3.6 MiB cum; unmapped: >0.0 MiB;   
> 0.0 MiB cum

Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-unbreak-memz.patch
2 files changed, 30 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/9870/1
--
To view, visit http://gerrit.cloudera.org:8080/9870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
Gerrit-Change-Number: 9870
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>

Reply via email to