Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9854 )
Change subject: [examples] Update collectl example ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc File examples/java/collectl/README.adoc: http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc@27 PS1, Line 27: pre-defined schema. > do you think it's worth adding something here like: Done http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc@60 PS1, Line 60: CREATE EXTERNAL TABLE `metrics` ( > I imagine the CREATE TABLE syntax has changed since this was first written. Done http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc@97 PS1, Line 97: 0 > maybe update to scala 2.11 and kudu 1.7? Done -- To view, visit http://gerrit.cloudera.org:8080/9854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5d0385e51724f1f462e059603f983a3f3408d96 Gerrit-Change-Number: 9854 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 02 Apr 2018 06:42:07 +0000 Gerrit-HasComments: Yes
