Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9854 )
Change subject: [examples] Update collectl example ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc File examples/java/collectl/README.adoc: http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc@27 PS1, Line 27: pre-defined schema. do you think it's worth adding something here like: NOTE: this code is meant as an example of Java API usage and is not meant to be a full-featured solution for storing metrics. ... or something to that effect? eg if someone submitted a bunch of patches to make this into a "better collectl storage" we might reject them since the idea is to be a condensed example rather than something useful on its own. http://gerrit.cloudera.org:8080/#/c/9854/1/examples/java/collectl/README.adoc@97 PS1, Line 97: 0 maybe update to scala 2.11 and kudu 1.7? -- To view, visit http://gerrit.cloudera.org:8080/9854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5d0385e51724f1f462e059603f983a3f3408d96 Gerrit-Change-Number: 9854 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 01:42:34 +0000 Gerrit-HasComments: Yes
