Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9452 )
Change subject: KUDU-2293 fix cleanup after failed copies ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9452/5/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/9452/5/src/kudu/tserver/tablet_copy_client.cc@302 PS5, Line 302: // Also validate the term of the source peer, in case they are > I feel like this class would be easier to follow if we just always called A Yeah, that's fair. I'm going to go with kInitialized, kStarting, kStarted, kFinishing, and kFinished. http://gerrit.cloudera.org:8080/#/c/9452/5/src/kudu/tserver/tablet_copy_client.cc@459 PS5, Line 459: // > Hmm, why load now and not replace anymore? Doesn't this make it more likely Great question, this wasn't really clear: with LoadFromSuperBlock instead of Replace, the only call that can fail due to a disk error is DeleteTabletData(), which flushes anyway. I'll update the comments. -- To view, visit http://gerrit.cloudera.org:8080/9452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0459d484a3064aa2de392328e2910c9f6741be04 Gerrit-Change-Number: 9452 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 21:42:12 +0000 Gerrit-HasComments: Yes
