Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9452 )
Change subject: KUDU-2293 fix cleanup after failed copies ...................................................................... Patch Set 7: The last failure was actually related to the change. In patch set 6, I'd moved the copy state machine to kStarting a bit too early, even based on my own descriptions of the states. The result was that the replica's metadata was incorrectly overwritten (the copy would end early because to an invalid term, and proceed to Abort() and overwrite the tablet metadata with the invalid superblock!) I've updated the placement of the state machine to match the descriptions, which avoids this. I looped TestRejectRogueLeader 200 times to ensure it doesn't run into the issues (before it would happen ~15/200). -- To view, visit http://gerrit.cloudera.org:8080/9452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0459d484a3064aa2de392328e2910c9f6741be04 Gerrit-Change-Number: 9452 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Tue, 03 Apr 2018 01:51:18 +0000 Gerrit-HasComments: No
