Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9895
to review the following change.
Change subject: KUDU-2395 (part 1): cache logged-in user
......................................................................
KUDU-2395 (part 1): cache logged-in user
The name of the current logged-in user is not expected to change over
time once the process is running. If it did change this could cause
strange effects with ACL enforcement, for one, or result in outbound RPC
connections switching credentials during the process lifetime.
Additionally, as pointed at in KUDU-2395, the lookup of the user name
from the UID sometimes needs to go to external services which may be
slow and incur lock contention.
This patch switches to computing the local username only once and
reusing the result on all subsequent lookups.
Change-Id: Ib4500d89dd91e8eed6e4ae0661b886ab3c105130
---
M src/kudu/util/user.cc
1 file changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/9895/1
--
To view, visit http://gerrit.cloudera.org:8080/9895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4500d89dd91e8eed6e4ae0661b886ab3c105130
Gerrit-Change-Number: 9895
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
