Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9881 )
Change subject: [tools] ksck improvements [1/n]: Eliminate KsckMaster class ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9881/2/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/9881/2/src/kudu/tools/ksck-test.cc@124 PS2, Line 124: using KsckCluster::tables_; : using KsckCluster::tablet_servers_; > Yes, it makes the base class's protected tables_ and tablet_servers_ member Interesting, I hadn't seen this before. Is this preferred over `friend class`es and `FRIEND_TEST`s? -- To view, visit http://gerrit.cloudera.org:8080/9881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f9e244b6ba10e11327c744abc1ac72a9b2ab1c Gerrit-Change-Number: 9881 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 03 Apr 2018 21:03:47 +0000 Gerrit-HasComments: Yes
