Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9881 )
Change subject: [tools] ksck improvements [1/n]: Eliminate KsckMaster class ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9881/2/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/9881/2/src/kudu/tools/ksck-test.cc@124 PS2, Line 124: using KsckCluster::tables_; : using KsckCluster::tablet_servers_; > Interesting, I hadn't seen this before. Is this preferred over `friend clas In this case, I think so, because what we are saying is "hey, this is MockKsckCluster, and any and all tests are free to jiggle its internals to set up their test cases". FRIEND_TEST does that on a test-by-test basis, and to me comes with the connotation that its just a few special tests getting access to a "real" class. Here the entire point is that a MockKsckCluster exists to be arranged suitably to test for the right output from ksck. -- To view, visit http://gerrit.cloudera.org:8080/9881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f9e244b6ba10e11327c744abc1ac72a9b2ab1c Gerrit-Change-Number: 9881 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 03 Apr 2018 21:07:27 +0000 Gerrit-HasComments: Yes
