Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 )
Change subject: rowset_metadata: cache min/max encoded keys ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/cfile_set.cc@154 PS7, Line 154: : > instead of checking for .empty(), should we make these optional? an empty e Done http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/diskrowset.cc@80 PS7, Line 80: TAG_FLAG(rowset_metadata_store_keys, experimental); > let's tag as experimental for now as well, since we may well make this defa Done http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/rowset_metadata.h File src/kudu/tablet/rowset_metadata.h: http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/rowset_metadata.h@244 PS7, Line 244: last_durable_redo_dms_id_(kNoDurableMemStore) { > per comment elsewhere, these probably should be optional<> Done http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/rowset_metadata.cc File src/kudu/tablet/rowset_metadata.cc: http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/rowset_metadata.cc@83 PS7, Line 83: max_encoded_key_ = boost::none; > I think we need to set them to 'none' in the else case -- it seems all of t Done http://gerrit.cloudera.org:8080/#/c/9372/7/src/kudu/tablet/rowset_metadata.cc@164 PS7, Line 164: set_min_encoded_key(*min_encoded_ > is this different than just using set_mutable_min_encoded_key(min_encoded_k Ah, good callout. I tried looking at the generated code and it seems like there's not too much of a difference, but set_mutable_min_encoded_key() is definitely more idiomatic. -- To view, visit http://gerrit.cloudera.org:8080/9372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d6f7160e3a7188753684e063963110f70e9b8d Gerrit-Change-Number: 9372 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 01:30:32 +0000 Gerrit-HasComments: Yes
