Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 )
Change subject: rowset_metadata: cache min/max encoded keys ...................................................................... Patch Set 8: (2 comments) > Patch Set 8: > > (5 comments) http://gerrit.cloudera.org:8080/#/c/9372/8/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/9372/8/src/kudu/tablet/cfile_set.cc@159 PS8, Line 159: rowset_metadata_->has_min_encoded_key() && : rowset_metadata_->has_max_encoded_key() Gonna merge these since I think it'll be cleaner. http://gerrit.cloudera.org:8080/#/c/9372/8/src/kudu/tablet/rowset_metadata.cc File src/kudu/tablet/rowset_metadata.cc: http://gerrit.cloudera.org:8080/#/c/9372/8/src/kudu/tablet/rowset_metadata.cc@162 PS8, Line 162: DCHECK_EQ(min_encoded_key_ == boost::none, max_encoded_key_ == boost::none); I think this is a valid intermediary state so I'm going to remove this. -- To view, visit http://gerrit.cloudera.org:8080/9372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d6f7160e3a7188753684e063963110f70e9b8d Gerrit-Change-Number: 9372 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 04 Apr 2018 01:49:10 +0000 Gerrit-HasComments: Yes
