Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 )
Change subject: KUDU-16: python client support for limits ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9924/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/9924/2/python/kudu/tests/test_scanner.py@67 PS2, Line 67: self.assertEqual(len(tuples), min(limit, len(self.tuples))) > I missed this in the first pass. Why is this 'min' necessary here? is this (len(tuples) <= limit) is definitely correct, but asserting equality is a stricter guarantee that we get exactly as many as we're expecting. In this case, we are testing limits both below and above the total number of rows, and at the higher end, we're capped by the number of rows. I can change it if you'd like, or at the very least make it more obvious what this is testing. -- To view, visit http://gerrit.cloudera.org:8080/9924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e24ff45c7dd359b400e4270fe7573305075b39 Gerrit-Change-Number: 9924 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 02:15:21 +0000 Gerrit-HasComments: Yes
