Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 )
Change subject: KUDU-16: python client support for limits ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9924/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/9924/2/python/kudu/tests/test_scanner.py@67 PS2, Line 67: scanner.set_limit(limit) > (len(tuples) <= limit) is definitely correct, but asserting equality is a s oh, I missed that it was len(self.tuples) on the right hand and not len(tuples). Is len(self.tuples) the same as self.nrows here? If so, I think the latter is more obvious -- To view, visit http://gerrit.cloudera.org:8080/9924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e24ff45c7dd359b400e4270fe7573305075b39 Gerrit-Change-Number: 9924 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 05:09:55 +0000 Gerrit-HasComments: Yes
