Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9923 )
Change subject: WIP KUDU-16 pt 3: add per-scan-token limits ...................................................................... Patch Set 1: (1 comment) Code LGTM, but I could go either way on whether to include this at all. http://gerrit.cloudera.org:8080/#/c/9923/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9923/1//COMMIT_MSG@19 PS1, Line 19: sure this is actually a useful API or the one that we want to expose. > yea, Im not sure this API provides much value beyond the caller just specif We chatted about this on Slack yesterday, but my thoughts are that we should definitely support setting a limit after re-hydrating the token, but providing this API as well might be useful, and it seems like it will be low maintenance overhead. I checked out the Spark integration to see if we could take advantage of it their, but it doesn't look like the RelationProvider interface exposes any kind of Limit hooks, so I guess I don't have any concrete examples where it will be useful. -- To view, visit http://gerrit.cloudera.org:8080/9923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I655f07f10a9a99e9766402729361de97e929136a Gerrit-Change-Number: 9923 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 18:09:53 +0000 Gerrit-HasComments: Yes
