Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 )
Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails ...................................................................... Patch Set 3: Code-Review+2 (2 comments) LGTM, but I'll wait for Lars to weigh in again before pushing. http://gerrit.cloudera.org:8080/#/c/9934/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9934/1//COMMIT_MSG@11 PS1, Line 11: cert.pem has 2 certificates in it: > Mike Yoder commented on the JIRA saying that this should be supported, so I I always thought this was the common case, where the trust store would contain just root CA certs, and leaf certs would be required to ship around all intermediaries up to an excluding the root. At least that's how it's typically done on the web, afaik. http://gerrit.cloudera.org:8080/#/c/9934/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9934/3//COMMIT_MSG@28 PS3, Line 28: TODO: Add a test case that has multiple intermediate CAs. Right now we're testing Maybe make a note in the JIRA about this TODO. I assume you want to land this patch without waiting for the additional test? -- To view, visit http://gerrit.cloudera.org:8080/9934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4af35e97ec6f91c1d9ed902128bd7f4e260f0f4 Gerrit-Change-Number: 9934 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 22:28:56 +0000 Gerrit-HasComments: Yes
