Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9934 )
Change subject: KUDU-2401: External TLS certificate with Intermediate CA in server cert file fails ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Carry +2. http://gerrit.cloudera.org:8080/#/c/9934/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9934/1//COMMIT_MSG@11 PS1, Line 11: cert.pem has 2 certificates in it: > I always thought this was the common case, where the trust store would cont Thanks, that makes sense. We weren't sure before this. http://gerrit.cloudera.org:8080/#/c/9934/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9934/3//COMMIT_MSG@28 PS3, Line 28: TODO: Add a test case that has multiple intermediate CAs. Right now we're testing > Maybe make a note in the JIRA about this TODO. I assume you want to land t Done http://gerrit.cloudera.org:8080/#/c/9934/3/src/kudu/security/test/test_certs.cc File src/kudu/security/test/test_certs.cc: http://gerrit.cloudera.org:8080/#/c/9934/3/src/kudu/security/test/test_certs.cc@509 PS3, Line 509: // The 'cert_file' here contains the serverCert and intermediateCA. > nit: refer to the function arguments instead. Done http://gerrit.cloudera.org:8080/#/c/9934/3/src/kudu/security/test/test_certs.cc@765 PS3, Line 765: // The 'cert_file' here contains the serverCert and intermediateCA. > same here Done -- To view, visit http://gerrit.cloudera.org:8080/9934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4af35e97ec6f91c1d9ed902128bd7f4e260f0f4 Gerrit-Change-Number: 9934 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:02:30 +0000 Gerrit-HasComments: Yes
