Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9965 )
Change subject: KUDU-2191 (9/n): HMS Catalog should short-circuit no-op alter and create table calls ...................................................................... KUDU-2191 (9/n): HMS Catalog should short-circuit no-op alter and create table calls This tweaks the HMS catalog class introduced in part 7 to be more flexible with how tables are created and altered. In particular, when altering, renaming, or creating a table entry in the HMS, it returns an OK status if the HMS already has the proper table entry, effectively short-circuiting the operation. Some short-circuiting existed before, but this makes it apply more uniformly in more situations. This is necessary for the notification listener to function correctly, since it's not always possible to determine which notification log events have aready been applied. I also took the opportunity to refactor HMS catalog a bit, since otherwise it would have been very unweildy to implement this functionality. I've added some specific test cases to hms_catalog-test, and some error message strings have changed slightly. Change-Id: I9c3594db0db253bc88e032b8c5aa2c8667c49853 Reviewed-on: http://gerrit.cloudera.org:8080/9965 Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Hao Hao <hao....@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/hms/hms_catalog-test.cc M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/integration-tests/master_hms-itest.cc 6 files changed, 134 insertions(+), 85 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Hao Hao: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9c3594db0db253bc88e032b8c5aa2c8667c49853 Gerrit-Change-Number: 9965 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
