Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10062 )

Change subject: run-test.sh: treat empty gzipped output files as text files
......................................................................

run-test.sh: treat empty gzipped output files as text files

I saw a test run where pstack_watcher-test timed out and gzip didn't produce
any output. Thus, we ended up with an empty pstack_watcher-test.txt.gz file
which is corrupt by definition; there should at least be a gzip header.

If this happens, let's treat the empty file as an empty text file so that
subsequent output file post-processing (which uses commands like zcat/zgrep)
doesn't fail.

Importantly, the pstack_watcher-test timeout does NOT benefit from this fix.
That's because pstack_watcher-test was being traced by gdb, so it couldn't
deliver itself a SIGABRT to timeout after 900 seconds. Instead, ctest killed
it after 930 seconds by sending a SIGKILL to run-test.sh itself, thus
preventing this cleanup code from running.

Change-Id: I0fbe13982412f9113b27afbc40635f8945c45f09
Reviewed-on: http://gerrit.cloudera.org:8080/10062
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <t...@apache.org>
---
M build-support/run-test.sh
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fbe13982412f9113b27afbc40635f8945c45f09
Gerrit-Change-Number: 10062
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to