Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as a metric ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10076/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10076/1//COMMIT_MSG@7 PS1, Line 7: KUDU-2287 Expose election failures as a metric > I opted for the counter as it was more precise as we don't have "time since You can do "time since successful election" as a function gauge, which is a type of metric where a function is called to get the metric value when e.g. someone hits /metrics. The tradeoff is that function gauges are more expensive and we'd be adding one instance per tablet replica. We already have at least one per-replica function gauge, IIRC, namely size on-disk, so I think it won't be too bad to have another, esp since all it will do is subtract off of Now(). -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 17 Apr 2018 17:38:31 +0000 Gerrit-HasComments: Yes
