Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as a metric ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10076/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10076/1//COMMIT_MSG@7 PS1, Line 7: KUDU-2287 Expose election failures as a metric The JIRA suggests either this or an actual wall clock time since there was a stable leader. I'm leaning slightly towards the time-based option vs a counter, since the time is more user-interpretable. eg if a replica hasn't had a leader for 60 seconds, I understand what that means, but if it hasn't had a leader for 10 elections I'm not really sure how long that is, particularly given randomization and backoff. Would it be too tricky to use a time based metric here? Or do you think there is some value to a count instead of time? -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:36:45 +0000 Gerrit-HasComments: Yes
