Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10088
to review the following change.
Change subject: ksck: add virtual destructor to KsckCluster
......................................................................
ksck: add virtual destructor to KsckCluster
Fixes the following warning when building with clang-7:
In file included from ../../src/kudu/tools/ksck_remote.cc:18:
In file included from ../../src/kudu/tools/ksck_remote.h:21:
In file included from
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:82:
In file included from
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/shared_ptr.h:52:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/shared_ptr_base.h:578:8:
warning: delete called on non-final 'kudu::tools::RemoteKsckCluster'
that has virtual functions but non-virtual destructor
[-Wdelete-non-virtual-dtor]
delete __p;
Change-Id: I6f6f0336332289543d103811401b142d383441a0
---
M src/kudu/tools/ksck.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/10088/1
--
To view, visit http://gerrit.cloudera.org:8080/10088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f6f0336332289543d103811401b142d383441a0
Gerrit-Change-Number: 10088
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
