Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 )
Change subject: Modify fix_includes.py for Kudu usage, add a wrapper ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu.py@49 PS2, Line 49: nit: extra space http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu/iwyu-filter.awk@a33 PS2, Line 33: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : I would appreciate if we could keep this information elsewhere. Or, maybe, have some special target to run the 'wholesome' IWYU build to check every file, not just incremental that the 'iwyu' target does. -- To view, visit http://gerrit.cloudera.org:8080/10106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9 Gerrit-Change-Number: 10106 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 18:26:59 +0000 Gerrit-HasComments: Yes
