Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10106
to review the following change.
Change subject: Modify fix_includes.py for Kudu usage, add a wrapper
......................................................................
Modify fix_includes.py for Kudu usage, add a wrapper
This makes a few small changes to the upstream fix_includes.py script:
- We name our tests 'foo-test.cc' instead of 'foo_test.cc'. Expands
the regex appropriately.
- Add support for 'IWYU pragma: keep' to avoid removing duplicate
headers. Without this, it was attempting to remove the duplicate
include in bitshuffle_arch_wrapper.cc which includes the bitshuffle
header twice with different #defines
- Adds a --blank_line_between_c_and_cxx_includes option which preserves
the style that we use.
- Adds support for differentiating between thirdparty <foo> includes
versus system <foo> includes by checking for file existence in a set
of directories passed on the command line. Google apparently uses
quoted includes like "protobuf/foo.h" for this purpose whereas we use
<>.
This also adds a simple wrapper script build-support/fix_includes.py
which handles passing the appropriate options to fix_includes.py.
Currently the wrapper script only supports the "sort includes" mode of
operation but I plan to extend it to also support the "fix IWYU issues"
mode.
Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9
---
A build-support/fix_includes.py
M build-support/iwyu/fix_includes.py
M src/kudu/cfile/bitshuffle_arch_wrapper.cc
3 files changed, 125 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10106/1
--
To view, visit http://gerrit.cloudera.org:8080/10106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9
Gerrit-Change-Number: 10106
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
