Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10077 )
Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle File java/kudu-spark-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle@34 PS7, Line 34: provided libs.yetusAnnotations > Seems like this should either be compile or optional. Who would be providi oh yeah, I should comment on this. Scala is noisy about missing annotations that it stubs. So I used provided to make it available on the classpath, but prevent it from being a downstream dependency. -- To view, visit http://gerrit.cloudera.org:8080/10077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91 Gerrit-Change-Number: 10077 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 19:35:48 +0000 Gerrit-HasComments: Yes
